Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can not create category by click in category select component #4658

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 25, 2023

What type of PR is this?

/area console
/kind bug
/milestone 2.10.x

What this PR does / why we need it:

修复在分类选择组件中,无法通过点击创建分类的问题。

image

Which issue(s) this PR fixes:

Fixes #4606

Special notes for your reviewer:

在任意一个分类选择组件输入一个不存在的分类,根据提示点击创建,观察是否创建成功即可。

Does this PR introduce a user-facing change?

修复 Console 端的分类选择组件中,无法通过点击创建不存在的分类的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Sep 25, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 25, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #4658 (3d08c7b) into main (5fa0056) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4658   +/-   ##
=========================================
  Coverage     60.98%   60.98%           
  Complexity     2610     2610           
=========================================
  Files           378      378           
  Lines         13551    13551           
  Branches        959      959           
=========================================
  Hits           8264     8264           
  Misses         4822     4822           
  Partials        465      465           

@LIlGG
Copy link
Member

LIlGG commented Sep 26, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Sep 26, 2023

/meow

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 26, 2023

@ruibaby: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang JohnNiang merged commit 97c92d0 into halo-dev:main Sep 26, 2023
2 checks passed
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.9版本安装后,直接新建分类失败,无法新建网站分类
4 participants