Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.9] fix: bundle resources cache version may duplicate #4626

Conversation

halo-dev-bot
Copy link
Collaborator

This is an automated cherry-pick of #4591

/assign guqing

修复 bundle resource 的缓存 key 生成可能会重复的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 18, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@JohnNiang JohnNiang added this to the 2.9.x milestone Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #4626 (d6e5de3) into release-2.9 (1c74bde) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##             release-2.9    #4626      +/-   ##
=================================================
+ Coverage          61.05%   61.11%   +0.06%     
- Complexity          2562     2566       +4     
=================================================
  Files                373      373              
  Lines              13153    13156       +3     
  Branches             937      937              
=================================================
+ Hits                8030     8040      +10     
+ Misses              4670     4663       -7     
  Partials             453      453              
Files Changed Coverage Δ
...core/extension/service/impl/PluginServiceImpl.java 62.39% <100.00%> (+7.13%) ⬆️

@f2c-ci-robot f2c-ci-robot bot merged commit 4fd076f into halo-dev:release-2.9 Sep 18, 2023
2 checks passed
@JohnNiang JohnNiang modified the milestones: 2.9.x, 2.9.2 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants