Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update download url of presets plugin #4615

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 17, 2023

What type of PR is this?

/area core
/kind cleanup

What this PR does / why we need it:

修改预设插件的下载地址,目前四个预设插件的仓库都已经转移到 halo-dev 组织。

Special notes for your reviewer:

需要测试 ./gradlew downloadPluginPresets 是否能够正常下载预设插件。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 17, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and minliacom September 17, 2023 05:45
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Merging #4615 (74650cd) into main (e13563b) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4615   +/-   ##
=========================================
  Coverage     61.04%   61.04%           
  Complexity     2566     2566           
=========================================
  Files           374      374           
  Lines         13168    13168           
  Branches        938      938           
=========================================
  Hits           8039     8039           
  Misses         4676     4676           
  Partials        453      453           

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guqing
Copy link
Member

guqing commented Sep 18, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit da2d56e into main Sep 18, 2023
@guqing guqing deleted the ruibaby-patch-1 branch September 18, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants