-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support running plugins from JAR in development mode #4589
Conversation
57d8662
to
af28b58
Compare
Codecov Report
@@ Coverage Diff @@
## main #4589 +/- ##
============================================
- Coverage 61.11% 61.02% -0.09%
- Complexity 2570 2571 +1
============================================
Files 374 375 +1
Lines 13171 13181 +10
Branches 938 941 +3
============================================
- Hits 8049 8044 -5
- Misses 4669 4684 +15
Partials 453 453
|
/cc @halo-dev/sig-halo |
@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-dev/sig-halo. Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
功能符合预期。
/ping @halo-dev/sig-halo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ping @halo-dev/sig-halo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, LIlGG The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/milestone 2.10.x
/area core
What this PR does / why we need it:
支持在开发模式下通过 JAR 运行插件
从此版本开始 BasePlugin 的子类建议使用 BasePlugin(PluginContext context) 构造函数,而不要使用之前的 BasePlugin(PluginWrapper wrapper) 构造函数。BasePlugin(PluginWrapper wrapper) 构造函数将计划在后续版本移除 ,当移除构造函数后不再将 PluginWrapper 暴露给插件使用,它只应该在 halo core 使用。
how to test it?
halo.plugin.fixed-plugin-path
插件是否正确运行Which issue(s) this PR fixes:
Fixes #2908
Does this PR introduce a user-facing change?