Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to keeep length of PAT stable #5366

Closed
JohnNiang opened this issue Feb 18, 2024 · 1 comment · Fixed by #5374
Closed

Request to keeep length of PAT stable #5366

JohnNiang opened this issue Feb 18, 2024 · 1 comment · Fixed by #5374
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement.

Comments

@JohnNiang
Copy link
Member

Your current Halo version

2.13.0-SNAPSHOT

Describe this feature

In #4598, I implemented the PAT mechanism using JWT as token format. But the token is too long, making it inconvenient for end users to use.

Maybe we could follow up https://github.blog/2021-04-05-behind-githubs-new-authentication-token-formats/ to create a shorter random PAT instead of using JWT.

Additional information

/kind improvement
/area core

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/core Issues or PRs related to the Halo Core labels Feb 18, 2024
@JohnNiang
Copy link
Member Author

There is a disadvantage worth noting, short token means that it cannot carry payload and must store in the database.

Therefore, I plan to remove roles information from PAT first to keep length of PAT stable.

/retitle Request to keeep length of PAT stable

@f2c-ci-robot f2c-ci-robot bot changed the title Request to support shorter PAT Request to keeep length of PAT stable Feb 19, 2024
@f2c-ci-robot f2c-ci-robot bot closed this as completed in 333422a Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant