Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix API misuse in the sample #491

Merged
merged 1 commit into from
Jan 11, 2025
Merged

fix: fix API misuse in the sample #491

merged 1 commit into from
Jan 11, 2025
+2 −2

Conversation

HowieHz
Copy link
Contributor

@HowieHz HowieHz commented Jan 10, 2025 •
edited by ruibaby
Loading

fix #490

None

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 3:54pm

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 10, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby January 10, 2025 02:10
@ruibaby
Copy link
Member

ruibaby commented Jan 11, 2025

感谢贡献，需要同时修改一下：https://github.com/halo-dev/docs/blob/main/versioned_docs/version-2.20/developer-guide/theme/template-variables/index_.md

@HowieHz
Copy link
Contributor Author

HowieHz commented Jan 11, 2025

感谢贡献，需要同时修改一下：https://github.com/halo-dev/docs/blob/main/versioned_docs/version-2.20/developer-guide/theme/template-variables/index_.md

已修改❤

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 11, 2025
ruibaby
ruibaby approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2025
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 2a08da5 into halo-dev:main Jan 11, 2025
3 checks passed
@HowieHz HowieHz deleted the patch-1 branch January 11, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby approved these changes

@guqing guqing Awaiting requested review from guqing

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

开发者指南-主题开发-模板编写-首页 中的示例 totalPages 填成 total 了
2 participants
@HowieHz @ruibaby