Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain validation behavior #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jniebuhr
Copy link

It is stated in the Readme that a validation like validates :email, email: { domain: true } will work, which it doesn't.
This pull request fixes this behavior.
It also includes a fix that will catch parsing errors when using the DomainValidator separately.

@jniebuhr
Copy link
Author

The 1.9 build seems to be broken because of it's dependencies.

@hallelujah
Copy link
Owner

Hello,

Sorry for the late answer. I had basically no time to be involved this year.
I fixed some of the dependencies lately. Could you please rebase your work so we may consider merging this.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants