Revert LineHeight bug fix #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InlineContent is not supposed to have its own ParagraphStyle. That kind of workaround makes the content essentially "non-inline". Each inline content composable gets its own Paragraph. Instead, we should address the root of the problem which stems from the fact that default Material3 theming adds LineHeight by default. Sample project now uses Material3 and overrides the default LineHeight to `TextUnit.Unspecified` in its theming. Inline content strictly respecting the line height argument should be addressed by the Compose team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InlineContent is not supposed to have its own ParagraphStyle. That kind of workaround makes the content essentially "non-inline". Each inline content composable gets its own Paragraph. Instead, we should address the root of the problem which stems from the fact that default Material3 theming adds LineHeight by default.
Sample project now uses Material3 and overrides the default LineHeight to
TextUnit.Unspecifiedin its theming. Inline content strictly respecting the line height argument should be addressed by the Compose team.