-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update dependencies in hale-platform to resolve security issues #50
Conversation
c2855e8
to
b7e8ad2
Compare
a274c7e
to
7432c00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you perform any tests using an update site your changes for hale studio? What were the results?
Generally the main part of the process of updating/changing the dependencies in the platform is testing these changes in hale studio and applying the related changes/fixes the both the platform and hale studio.
Before merging changes here we need to make sure they have been validated with hale studio. Otherwise we end up with a state in hale-platform that someone else could not work with without resolving the related issues first.
build.gradle
Outdated
@@ -91,7 +91,7 @@ include { | |||
} | |||
|
|||
from('modules/shared/logging.gradle') { | |||
slf4jAndLogback '1.7.10', '1.0.13' | |||
slf4jAndLogback '1.7.25', '1.0.13' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did changing logback to 1.2.12
cause any problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should I change it to a lower version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first version is the SLF4J version, with you changes at 1.7.25
, the second version is the logback version, now at 1.0.13
.
7432c00
to
e15bb02
Compare
I haven't. As I couldn't conclude successfully the process of updating the resource bundles. |
Do you mean hale-build-support?
|
Right! I can use a local folder. I'll do that. |
e15bb02
to
91c11b8
Compare
L.E. I have it
Not sure how to change the version...if I just change the date I get |
@emanuelaepure10 When you use the Eclipse editor for the target file (not editing the source XML) you should be able to edit the update site entry, and in the dialog that opens then select the item that is actually contained in the update site. |
@stempler Thank you. |
91c11b8
to
97a8669
Compare
Open points where I would need help to solve them:
which are giving problems.
Thank you |
97a8669
to
28a402e
Compare
build.gradle
Outdated
from('modules/shared/logging.gradle') { | ||
slf4jAndLogback '1.7.10', '1.0.13' | ||
from('modules/logging.gradle') { | ||
slf4jAndLogback '1.7.36', '1.0.13' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please again include the update to logback from 1.0.13
to 1.2.12
? Thank you
update libraries ING-4067
28a402e
to
b1a16b8
Compare
update slf4jAndLogback from 1.0.13 to 1.2.12
ING-4067