Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade GeoTools dependency to 29.2 #49

Closed
wants to merge 1 commit into from

Conversation

florianesser
Copy link
Member

ING-4041

Copy link
Contributor

@emanuelaepure10 emanuelaepure10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly for me!

@florianesser
Copy link
Member Author

If I understand the GitHub Actions output correctly, it complains about vulnerabilities found in the libraries. @stempler Would you say that this PR can be merged anyway or is there anything that I can/should do first?

@stempler
Copy link
Member

@florianesser I would see as the condition for merging that this works in hale studio, so that whoever does the next update to the target platform can build on it without needing to resolve issues first that stem from the Geotools changes.
Does it work in hale studio (build+tests) with the changes? If yes would I would propose to directly follow-up with the integration in hale studio.

@florianesser
Copy link
Member Author

Ah, didn't think about that, thanks for the clarification, @stempler. In that case this PR doesn't make sense IMO and the bump of the GeoTools version should be done as part of ING-4083 together will all other changes to the platform that might be necessary.

@stempler
Copy link
Member

Yes, though it can also be used as a starting point for the implementation ticket and e.g. remain open but as draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants