Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update referenced workflows #125

Closed

Conversation

florianesser
Copy link
Member

No description provided.

@florianesser florianesser requested a review from stempler May 7, 2024 11:26
@@ -8,12 +8,12 @@ on:

jobs:
check:
uses: wetransform/gha-workflows/.github/workflows/gradle-library-check.yml@ef7e7ff0d5f77914d591c783f3dcf854e3c4e204
uses: wetransform/gha-workflows/.github/workflows/gradle-library-check.yml@2a6fc2ee6aeac10bafcb841f1be6f780f2b5dac6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems when just using the commit sha here renovate will ignore it. I would prefer if we can let renovate watch for updates. I guess for that then the notation similar to here is needed.

Would you do the honor and create a release for the workflows so that you can use that version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you do the honor and create a release for the workflows so that you can use that version?

Created the release.

It seems when just using the commit sha here renovate will ignore it. I guess for that then the notation similar to here is needed.

Looks like it picked it up, there's this PR now. It uses the hash from the release but doesn't mention the version number, though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to add the version numbers, then it can properly differentiate between a major update and other updates. And presumably only reacts to releases and not every push to master.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created PR #127 for it

@florianesser
Copy link
Member Author

Closing in favour of #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants