Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: adapt usage of gradle-library workflow #124

Merged
merged 2 commits into from
May 7, 2024

Conversation

florianesser
Copy link
Member

As the gradle-tasks parameter of the referenced gradle-library was removed and replaced by build-tasks and publish-tasks in wetransform/gha-workflows@a30e8de the workflow here must be adapted accordingly.

SVC-1812

As the `gradle-tasks` parameter of the referenced `gradle-library` was removed
and replaced by `build-tasks` and `publish-tasks` in wetransform/gha-workflows@a30e8de
the workflow here must be adapted accordingly.

SVC-1812
@florianesser florianesser requested a review from stempler May 7, 2024 07:06
@@ -17,7 +17,8 @@ jobs:
uses: wetransform/gha-workflows/.github/workflows/gradle-library.yml@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also use this as opportunity to reference a specific version of the workflow repo instead of the master branch. Thank you!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I pinned the references to the latest gha-workflows commit.

I assume that an alternative to adapting the parameters would be to just use an older version of the workflow. Do you think that would be the better approach here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that an alternative to adapting the parameters would be to just use an older version of the workflow. Do you think that would be the better approach here?

Yes, using version 1 instead of 2 would resolve the issue as well, but it makes sense to do the update if we want to use the release workflow in the future.

@florianesser florianesser force-pushed the ci/fix-artifacts-job branch from 579ed96 to f6b02c6 Compare May 7, 2024 10:01
@florianesser florianesser merged commit b1559b1 into halestudio:devel May 7, 2024
2 of 3 checks passed
@florianesser florianesser deleted the ci/fix-artifacts-job branch May 7, 2024 11:20
Copy link

we-release bot commented Jun 19, 2024

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@we-release we-release bot added the released label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants