Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAL-1953: fix unmanaged deployment for server groups #1045

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

michpetrov
Copy link
Contributor

Issue: HAL-1953

Aside from the deployment not working there was also a problem with runtime-name not being treated as optional so I fixed that as well.

@michpetrov michpetrov requested a review from a team as a code owner January 4, 2024 12:53
@michpetrov michpetrov marked this pull request as draft January 4, 2024 13:09
@michpetrov
Copy link
Contributor Author

Switched to draft. I think there might be more issues related to runtime-name

@michpetrov michpetrov marked this pull request as ready for review January 4, 2024 17:01
Copy link
Member

@hpehl hpehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @michpetrov

@hpehl hpehl merged commit b08cd94 into hal:main Jan 5, 2024
2 checks passed
@michpetrov michpetrov deleted the hal-1953 branch January 5, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants