Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAL-1906] allow path serparator to be part of KVP #1037

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb commented Dec 18, 2023

Issue: https://issues.redhat.com/browse/HAL-1906

Just for review now. This will likely either need update in PathTemplate JDOC contract or just wont make it.
EDIT: to be precise, it allows delimiter to be part of V.

@baranowb baranowb requested a review from a team as a code owner December 18, 2023 11:25
@hpehl
Copy link
Member

hpehl commented Dec 22, 2023

Thanks for the PR @baranowb. I need some more time to review this and the PR for HAL-1917.

Copy link
Member

@hpehl hpehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @baranowb

@hpehl hpehl merged commit 92a492c into hal:main Jan 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants