Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Keyspace 포함 여부 필드 추가 및 테스트 보강 #44

Closed
wants to merge 2 commits into from
Closed

System Keyspace 포함 여부 필드 추가 및 테스트 보강 #44

wants to merge 2 commits into from

Conversation

seungh0
Copy link
Member

@seungh0 seungh0 commented Jul 7, 2024

  • Cassandra 3.x 버전에서 지원안하는 것 같아 확인 필요

seungh0
seungh0 commented Jul 7, 2024
View reviewed changes
.../src/main/java/kr/hakdang/cassdio/core/domain/cluster/keyspace/ClusterKeyspaceCommander.java Outdated
@@ -33,11 +33,12 @@ public class ClusterKeyspaceCommander extends BaseClusterCommander {
* @param session
* @return
*/
public List<String> allKeyspaceNames(CqlSession session) {
public List<String> allKeyspaceNames(CqlSession session, boolean includeSystemKeyspace) {
return session.execute(SimpleStatement.newInstance("DESC KEYSPACES"))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 3.x 지원 안하는거 같네요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헐.... 방법 찾아볼게요.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

지원합니다~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 1:0 no viable alternative at input 'DESC' ([DESC]...)

저희가 쓰는 라이브러리로 호출 할 때 뭔가 있는듯..

@seungh0 seungh0 closed this Jul 9, 2024
@seungh0 seungh0 deleted the feature/keyspace-list-system-filter branch July 28, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akageun akageun akageun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seungh0 @akageun