Update Homebrew Java installation docs for OSX #14729
Open
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-schultz
requested changes
Oct 15, 2024
|
@patrick-schultz - what version of Azul are we currently using in prod? I searched the repository and checked out all of the Dockerfiles but couldn't find the reference. |
patrick-schultz
approved these changes
Oct 16, 2024
ehigham
requested changes
Oct 16, 2024
| @@ -9,8 +9,7 @@ Install Hail on Mac OS X | |||
|
|
|||
| .. code-block:: | |||
|
|
|||
| brew tap homebrew/cask-versions | |||
| brew install --cask temurin8 | |||
| brew install zulu@11 | |||
|
|
|||
| You *must* pick a Java installation with a compatible architecture. If you have an Apple M1 or M2 | |||
There was a problem hiding this comment.
Since you're here, M3+ is now a thing so this could be reworded to something mroe future-proof like
Suggested change
| You *must* pick a Java installation with a compatible architecture. If you have an Apple M1 or M2 | |
| You *must* pick a Java installation with a compatible architecture. | |
| If, for example, your processor uses M-series Apple silicon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
When going through the documentation for installing Hail on OSX, I noticed that the syntax for installing Java via Homebrew was out of date.
This PR updates the documentation to use the latest syntax for Homebrew. It also updates the command to install version 11 of Temurin instead of version 8.
Security Assessment
Impact Description
This change updates documentation only and has no immediate end user impact.
This change updates the recommended version of Temurin to a newer version (11 vs. 8). It is reasonable to assume that the newer version is at least as secure as previous versions. So, there also should be no negative security impact on future users of this documentation.