Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new plugin [custom-cards/upcoming-media-card] #2372

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

mkanet
Copy link

@mkanet mkanet commented Feb 21, 2024

Checklist

  • I've read the publishing documentation.
  • I've added the HACS action to my repository.
  • (For integrations only) I've added the hassfest action to my repository.
  • The actions are passing without any disabled checks in my repository.
  • I've added a link to the action run on my repository below in the links section.
  • I've created a new release of the repository after the validation actions were run successfully.

Links

Link to current release: https://github.com/custom-cards/upcoming-media-card/releases/tag/0.4.4
Link to successful HACS action (without the ignore key): https://github.com/custom-cards/upcoming-media-card/actions/runs/7966912126
Link to successful hassfest action (if integration): <>

@tjorim
Copy link
Contributor

tjorim commented Feb 21, 2024

Please only 1 change per PR.

File not needed.
Copy link
Author

@mkanet mkanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I deleted the uncessary file.

@ludeeus
Copy link
Member

ludeeus commented Feb 21, 2024

Revert deleting that file.

@ludeeus ludeeus marked this pull request as draft February 21, 2024 07:37
@hacs-bot hacs-bot bot changed the title Add upcoming media card plugin file Adds new plugin [custom-cards/upcoming-media-card] Feb 21, 2024
Copy link
Author

@mkanet mkanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mkanet mkanet marked this pull request as ready for review March 2, 2024 19:38
@mkanet
Copy link
Author

mkanet commented Mar 2, 2024

Sorry, I forgot to mark this as "ready". Is should be good now.

@mkanet
Copy link
Author

mkanet commented Jun 24, 2024

@ludeeus please forgive me, I know you're very busy. I am curious I didnt do something incorrectly that might have delayed the approval/merge of my 4 PRs. I submitted them over 4 months ago. They already passed hassfest/validation. I just want to make sure I didnt do something wrong.

The frontend/integrations are relatively popular; and, hoping we can get them on HACS soon.

Thank you for your time.

@tjorim
Copy link
Contributor

tjorim commented Jun 24, 2024

All good, just wait. If you look at the PRs there are some open for longer.

@mkanet
Copy link
Author

mkanet commented Nov 3, 2024

@tjorim, forgive me for contacting you directly. It's been over 10 months since I originally submitted this this PR and 3 others. Can you please check to see if there is something wrong? Is there anything you can do to help move this forward? Thank you so much for your time.

@tjorim
Copy link
Contributor

tjorim commented Nov 3, 2024

There are still some PRs before you, currently around 2338.

@mkanet
Copy link
Author

mkanet commented Nov 4, 2024

Getting close! Thank you for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants