783 force stud address #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-run-on-push fix: update the workflows
…website into 783-force-stud-address * '783-force-stud-address' of github.com:hackerspace-ntnu/website: add union back change union type and edit test for empty mail updated skill missing email get emails from members without skill change to use converter when sending internal emails add convert stud email method
michaelbrusegard
previously approved these changes
Mar 13, 2024
CJGutz
dismissed
michaelbrusegard’s stale review
The merge-base changed after approval.
michaelbrusegard
approved these changes
Mar 13, 2024
CJGutz
dismissed
michaelbrusegard’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method that converts ntnu emails into stud.ntnu emails.
closes: #783 .
See issue why this is needed.
Added tests for the method.
Used the method for places where emails are sent to internal members.
Also did a little important change to the skill_missing_email text.