Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(applications): Add field to remove application group from the application page #765

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

CJGutz
Copy link
Member

@CJGutz CJGutz commented Sep 16, 2023

Added a boolean field to the application group model.
When True, the group is displayed on the page.
The reason to implement this is to prevent deleting application groups. They can be deleted later.
Another reason is to be able to remove its information from the application page while there are people having applied for a group. If the group were to be deleted, ApplicationGroupChoices for that group would also be deleted.

@CJGutz CJGutz requested a review from njal3001 September 18, 2023 08:00
Copy link
Contributor

@njal3001 njal3001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@njal3001 njal3001 merged commit 46af547 into master Sep 18, 2023
1 check passed
@michaelbrusegard michaelbrusegard deleted the feat/invisible-application-groups branch January 24, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants