Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: members page #68

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

feat: members page #68

wants to merge 19 commits into from

Conversation

lisayu03
Copy link

I have created an overview over all the members, and the individual page for each member. The icons for the skills are not the proper ones, since they have not yet been created. I'm unsure about the sizing and how to make it smoother (or if it's even done correctly🤡).

Please be mean 😭😭😭

Copy link
Member

@ZeroWave022 ZeroWave022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run bun lint and commit the changes.
There are a lot of unnecessary imports in a lot of files, so please remove whatever you don't use.
Some components have a lot of props destructured. Sometimes it may be easier to not do so, but instead just access them with props.discord, if the props include usernames and such.

messages/no.json Outdated Show resolved Hide resolved
messages/no.json Outdated Show resolved Hide resolved
src/app/[locale]/(default)/members/(header)/loading.tsx Outdated Show resolved Hide resolved
src/app/[locale]/(default)/members/(header)/page.tsx Outdated Show resolved Hide resolved
src/app/[locale]/(default)/members/[member]/page.tsx Outdated Show resolved Hide resolved
src/components/members/ItemGridSkeleton.tsx Outdated Show resolved Hide resolved
src/components/members/MemberCard.tsx Outdated Show resolved Hide resolved
src/components/members/ItemGrid.tsx Outdated Show resolved Hide resolved
src/components/members/MemberViewCard.tsx Outdated Show resolved Hide resolved
src/components/members/SkillCard.tsx Outdated Show resolved Hide resolved
@ZeroWave022
Copy link
Member

The gap between members on the grid on /members seems to be very large. I would recommend making it a bit smaller.
Also, please test that the pagination works by adding even more members.
The skills on each member page, that being /members/[id] don't need to be separated. I think maybe using a Separator would be easier and maybe look better.

@michaelbrusegard
Copy link
Member

Merge with dev first then I will take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants