-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved HealthHUD and damage popup feedback #905
Open
Fueredoriku
wants to merge
2
commits into
dev
Choose a base branch
from
feature/health-hud-polish
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toberge
reviewed
Dec 22, 2024
Fueredoriku
changed the title
Add sine wave animation for health HUD
Imporved HealthHUD and damage popup feedback
Dec 24, 2024
Fueredoriku
changed the title
Imporved HealthHUD and damage popup feedback
Improved HealthHUD and damage popup feedback
Dec 24, 2024
Fueredoriku
force-pushed
the
feature/health-hud-polish
branch
from
December 24, 2024 01:37
833235e
to
be8bd35
Compare
toberge
reviewed
Dec 24, 2024
@@ -95,6 +95,8 @@ public class PlayerHUDController : MonoBehaviour | |||
private PopupSpammer popupSpammer; | |||
public PopupSpammer PopupSpammer => popupSpammer; | |||
[SerializeField] | |||
private DamagePopupEmitter damagePopupEmitter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used in this class?
toberge
reviewed
Dec 24, 2024
{ | ||
// Implementation based of https://iquilezles.org/articles/palettes/ | ||
// Health is expected to be normalized. | ||
public static Color HealthPalette(float health) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No needuto specify that it's a palette here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.