Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spray can, fix GPU instantiation for decals #886

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Add spray can, fix GPU instantiation for decals #886

merged 1 commit into from
Dec 18, 2024

Conversation

Fueredoriku
Copy link
Contributor

@Fueredoriku Fueredoriku commented Dec 17, 2024 •
edited
Loading

  • Added a spray can with modifiable spray color!
  • Made the existing bullet decals use GPU instantiation (yikes, atleast we should see a decent performance increase now)
  • Fixed playerhands being in the wrong lightlayer for avoiding decals

Note: I'm not adding the spray cans to the maps in this PR, as I plan to add more props very soon and want to avoid conflicts
sprayCans

@Fueredoriku Fueredoriku self-assigned this Dec 17, 2024
@Fueredoriku Fueredoriku requested a review from toberge December 17, 2024 02:28
@Fueredoriku Fueredoriku force-pushed the feature/spray-can branch 2 times, most recently from 084a7b7 to a78bc2a Compare December 18, 2024 01:47
toberge
toberge approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Assets/Scripts/Interactables/SprayCan.cs Outdated Show resolved Hide resolved
Assets/Scripts/Interactables/SprayCan.cs Show resolved Hide resolved
@Fueredoriku Fueredoriku merged commit 9f6a579 into dev Dec 18, 2024
@Fueredoriku Fueredoriku deleted the feature/spray-can branch December 18, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toberge toberge toberge approved these changes

Assignees

@Fueredoriku Fueredoriku

Labels
None yet
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fueredoriku @toberge