Add look inversion settings #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toberge
force-pushed
the
feature/look-inversion-settings
branch
from
7c43d4e to
ada3a10
Compare
Fueredoriku
approved these changes
Nov 17, 2024
My problem with the original name was that it repeats the information that is already present in the class name, and in all cases (I think) the data instance thingy is accessed through the whole SettingsDataManager.SIngleton shebang. I'd like to resolve this more cleanly with read-only properties that access a private instance of the SettingsData, but that'll have to happen in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #874