Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negative chip count and multibidding AIs #719

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Fix negative chip count and multibidding AIs #719

merged 2 commits into from
Jun 8, 2024

Conversation

toberge
Copy link
Contributor

@toberge toberge commented Jun 8, 2024 •
edited
Loading

  • Fix negative chip count by ensuring that we can bid in both the command and client RPC
  • Fix AIs being able to cash out lots of chips instantly by rewriting their code to only perform bids once per evaluation

Closes #698

@toberge toberge requested a review from Fueredoriku June 8, 2024 19:46
Fueredoriku
Fueredoriku approved these changes Jun 8, 2024
View reviewed changes
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

Assets/Scripts/Auction/BiddingPlatform.cs Outdated Show resolved Hide resolved
@toberge toberge force-pushed the fix/double-check-bids branch from d4808ac to ea70c08 Compare June 8, 2024 21:29
@toberge toberge merged commit 397fbd4 into dev Jun 8, 2024
@toberge toberge deleted the fix/double-check-bids branch June 8, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fueredoriku Fueredoriku Fueredoriku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AI players and extra local players may get negative chips during auction
2 participants
@toberge @Fueredoriku