Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #704 #707

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Fix #704 #707

merged 2 commits into from
Jun 7, 2024

Conversation

Fueredoriku
Copy link
Contributor

No description provided.

@Fueredoriku Fueredoriku marked this pull request as ready for review June 7, 2024 19:39
@Fueredoriku Fueredoriku requested a review from toberge June 7, 2024 19:39
@Fueredoriku Fueredoriku linked an issue Jun 7, 2024 that may be closed by this pull request
Killing with shotguns grants 1 kill bonus per bullet #704
Closed
toberge
toberge approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, though the list of hit colliders in knockbackmodifier seems to be able to grow indefinitely, perhaps it should be a set or something?

@Fueredoriku Fueredoriku force-pushed the fix/shotgun-invocations branch from 1ab6849 to 7a95c37 Compare June 7, 2024 20:18
@Fueredoriku Fueredoriku merged commit 571c660 into dev Jun 7, 2024
@Fueredoriku Fueredoriku deleted the fix/shotgun-invocations branch June 7, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toberge toberge toberge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Killing with shotguns grants 1 kill bonus per bullet
2 participants
@Fueredoriku @toberge