Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bullet networking (attempt 2) #635

Merged
merged 4 commits into from
May 13, 2024
Merged

Bullet networking (attempt 2) #635

merged 4 commits into from
May 13, 2024

Conversation

toberge
Copy link
Contributor

@toberge toberge commented May 9, 2024 •
edited
Loading

Replaces the old PR #620 cuz I don't wanna overwrite that branch yet

Plan

  • Send info about other players to clients
  • Spawn and initialize players with guns
  • Simply make the correct gun fire on all clients/servers when it is fired by its owner
  • Use SteamID to identify players
  • Make the trail and so on actually show up on all clients

Extra that should be done beyond this

  • Transform this into firing from point and in direction that is given by player
  • Deal with allllll the hijinks (big one)
  • Provide seeds for random operations (e.g. lightning bolts)

Closes #640

@toberge toberge mentioned this pull request May 9, 2024
Closed
4 tasks
@toberge toberge force-pushed the feature/network-bullets2 branch 23 times, most recently from 0e253d5 to edeadfd Compare May 12, 2024 17:22
@toberge toberge marked this pull request as ready for review May 12, 2024 17:24
@toberge toberge requested a review from Fueredoriku May 12, 2024 17:24
toberge added 2 commits May 12, 2024 19:25
@toberge
Spawn players so that they can shoot online
223df1c 
- Dictionary with player info in the Tansport class
- This is populated when new players join, and synced with the other
  players
- Players are spawned and subsequently initialized with the help of this
  dictionary
- Went for a message after spawning for the initialization
@toberge
Remove HUD from network players
9d44a0e
@toberge toberge force-pushed the feature/network-bullets2 branch from edeadfd to a7c5f3c Compare May 12, 2024 17:25
@toberge toberge force-pushed the feature/network-bullets2 branch from a7c5f3c to 5a93bd5 Compare May 12, 2024 17:41
Fueredoriku
Fueredoriku approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!! 🎉

I just have couple of comments, but nothing big, so I'll leave you an approve 👍

Great work!

Assets/Mirror/Core/NetworkIdentity.cs Show resolved Hide resolved
Assets/Scripts/Augment/GunFactory.cs Outdated Show resolved Hide resolved
@toberge toberge force-pushed the feature/network-bullets2 branch from 5a93bd5 to c7b5f1c Compare May 13, 2024 16:35
@toberge toberge merged commit 377baf7 into dev May 13, 2024
@toberge toberge deleted the feature/network-bullets2 branch May 13, 2024 16:41
@Fueredoriku Fueredoriku mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fueredoriku Fueredoriku Fueredoriku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synchronize that a gun should fire
2 participants
@toberge @Fueredoriku