Feature/post match scoring #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WantedPoster.cs now sets text instead of using SetActive, thus text no longer moves around when new elements appear.
…ring # Conflicts: # Assets/Scenes/CraterTown.unity
Issues with assigning delegates in matchController before onRoundStart triggers is the reason for the new ienumerate
Adjusted Scoreboard
simplify WantedPoster.cs
…ring # Conflicts: # Assets/Scenes/CraterTown.unity # Assets/Scripts/Gamestate/MatchController.cs
Made it work. Removed unnecessary code. matchController now directs to the scoreboard manager when game ends. ScoreboardManager.cs then informs MatchController.cs when its complete so as to move to the next bidding scene.
Removed debug messages. Added separate camera animations for different scenes Fixed export settings for Scoreboard.fbx to function with unity coordinate system Allowed GrandCanyon to again be chosen as a map.
Fixed animation Fixed scaling issue on scoreboard Added sfx when new crime is revealed Reduced time between revealing crimes to one second Removed unnecessary audioSources
…ring # Conflicts: # Assets/Scenes/CraterTown.unity # Assets/Scenes/GrandCanyon.unity
toberge
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Nice work! 🎉 Now we'll finally be able to see our cowbots' life savings and blood-stained chips 🤠
However, I do have some concerns:
- There is no delay after the victor has been determined, possibly making it hard to notice who won in a close-cut standoff as you no longer see the "killed by player x" screen for the last two standing. Consider adding a delay of a couple of seconds before transitioning to the scoreboard animation.
- The chip entries are displayed very inconsistently:
Ideally they should stick to the bottom and have consistent spacing.
Overall it should be ready for Spillexpo, but we could squeeze in some polish.
- Consistent placement of the reward entries - and the reward box sticks to the bottom - Consistent font sizes
|
Revamped look: |
toberge
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
I would've liked to review this properly but it seems fine now (and I adjusted the scoreboard UI and delays a little). The choice of "crime" as the term for scoreboard reward entries seems odd and I'd like to see this refactored someday, but we ain't got time for that now 😔
…ring # Conflicts: # Assets/Prefabs/Gamestate/MatchManager.prefab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a scoreboard at the end of the round to tally the points players get.
Known issues/missing improvements: