Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapon construction #294

Merged
merged 18 commits into from
Nov 15, 2023
Merged

Weapon construction #294

merged 18 commits into from
Nov 15, 2023

Conversation

Fueredoriku
Copy link
Contributor

No description provided.

@Fueredoriku Fueredoriku force-pushed the feature/choose-weapon-part branch from 4ab9875 to 85b9255 Compare November 15, 2023 02:08
@Fueredoriku Fueredoriku linked an issue Nov 15, 2023 that may be closed by this pull request
@karofmah karofmah marked this pull request as ready for review November 15, 2023 14:14
Copy link
Contributor

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally we get to build our weapons 🎉
The stats seem to display correctly too 📊

image

Now, I do see a bunch of things to complain about in the current iteration of this UI, but most (if not all) can be left until after Spillexpo:

  • The timer is displayed on every screen involved in the process. I think we could do it similarly to the timer in the FPS rounds.
  • The gun's name is displayed, but no description of what the augments actually do, which might be an issue for some players, and this kinda makes the stats more important than the fancy functionality we add to the guns
  • The up/down arrows don't fit the style of RPR, this isn't a pixel art game last I checked 😉
  • Some gunparts are severely obscured by the UI background, like the pan extension:
    image

Assets/Scripts/Auction/AuctionDriver.cs Outdated Show resolved Hide resolved
Assets/Scripts/Control&Input/ItemSelectManager.cs Outdated Show resolved Hide resolved
Assets/Scripts/Control&Input/ItemSelectManager.cs Outdated Show resolved Hide resolved
@toberge
Copy link
Contributor

toberge commented Nov 15, 2023

for the record: just resolve my comments and merge this, the comments aren't that important

@karofmah karofmah merged commit d308790 into dev Nov 15, 2023
@karofmah karofmah deleted the feature/choose-weapon-part branch November 15, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

Weapon select screen
3 participants