Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add popup spammer #271

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Add popup spammer #271

merged 5 commits into from
Oct 31, 2023

Conversation

toberge
Copy link
Contributor

@toberge toberge commented Oct 22, 2023

Closes #267 (See issue for details)

image

More popups:
image

See this Figma for the assets

@toberge toberge force-pushed the feature/hacking-extension branch 2 times, most recently from a3aa9d5 to 2a6749a Compare October 24, 2023 17:55
@toberge toberge marked this pull request as ready for review October 24, 2023 19:10
@toberge toberge force-pushed the feature/hacking-extension branch 5 times, most recently from 0970751 to 1342eac Compare October 25, 2023 20:18
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great new feature! 😁 We'll have to come up with a fitting model soon (tm)!

I have some feedback I'd like your opinion on before I approve, mainly tied to the prefab-stuff

Assets/Scripts/UI/PopupSpammer.cs Outdated Show resolved Hide resolved
Assets/Scripts/UI/PopupSpammer.cs Show resolved Hide resolved
The popup images now reside in the popup prefab, which means much less
effort is required to add more images.
@toberge toberge force-pushed the feature/hacking-extension branch from 6fc22fb to e9615a4 Compare October 29, 2023 21:05
- Put PopupSpammer on the object it belongs to
- Reorder and add headers to fields on PlayerManager and
  PlayerHUDController
@toberge toberge requested a review from Fueredoriku October 30, 2023 09:52
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 😁👍

@toberge toberge merged commit 80ca100 into dev Oct 31, 2023
@toberge toberge deleted the feature/hacking-extension branch October 31, 2023 10:51
@Fueredoriku Fueredoriku linked an issue Nov 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

Lag spam for hacke-extension Programmere hacke-extension
2 participants