Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background to main menu #246

Merged
merged 9 commits into from
Nov 14, 2023
Merged

Add background to main menu #246

merged 9 commits into from
Nov 14, 2023

Conversation

ChrisKrane
Copy link
Contributor

No description provided.

@ChrisKrane ChrisKrane self-assigned this Oct 15, 2023
-Scene added behind main menu
-Camera moves when options button is clicked
-Camera Moves back to original view when back button is clicked
@ChrisKrane ChrisKrane linked an issue Nov 13, 2023 that may be closed by this pull request
7 tasks
@ChrisKrane ChrisKrane marked this pull request as ready for review November 13, 2023 15:11
@toberge
Copy link
Contributor

toberge commented Nov 13, 2023

image
The gallery doesn't work 🤔

Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks nice 😁👍

I think we should take a look at fixing the gallery before merging (maybe just do it as easy resetting the camera position to its old position when switching to gallery (and then back to you new position when changing back from the gallery) if thats what's causing this? Fixing the underlying problem for the gallery is not part of the scope of this PR I would say, so I would approve a quickfix like that)

Assets/Scripts/UI/MainMenu/MainMenuMoveCamera.cs Outdated Show resolved Hide resolved
@ChrisKrane
Copy link
Contributor Author

Great work, looks nice 😁👍

I think we should take a look at fixing the gallery before merging (maybe just do it as easy resetting the camera position to its old position when switching to gallery (and then back to you new position when changing back from the gallery) if thats what's causing this? Fixing the underlying problem for the gallery is not part of the scope of this PR I would say, so I would approve a quickfix like that)

Fixed with a small tweak to GalleryMenu.cs :)

Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, great first PR 🤠👍

@ChrisKrane ChrisKrane merged commit 1332d4a into dev Nov 14, 2023
@ChrisKrane ChrisKrane deleted the feature/new-main-menu branch November 14, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

New main menu
3 participants