Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/platform movement #243

Merged
merged 14 commits into from
Oct 15, 2023
Merged

Feature/platform movement #243

merged 14 commits into from
Oct 15, 2023

Conversation

karofmah
Copy link
Contributor

No description provided.

@Fueredoriku Fueredoriku changed the base branch from main to dev October 15, 2023 17:20
toberge
toberge requested changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platforms seem to work really well and don't glitch out when stomping the player 👍

However, I do have some minor and major comments about the code quality.

Assets/Scripts/Platforms/PlatformCollision.cs Outdated Show resolved Hide resolved
Assets/Scripts/Platforms/PlatformMovement.cs Outdated Show resolved Hide resolved
Assets/Scripts/Platforms/PlatformMovement.cs Outdated Show resolved Hide resolved
Assets/Scripts/Platforms/PlatformMovement.cs Show resolved Hide resolved
Assets/Scripts/Gamestate/MatchController.cs Show resolved Hide resolved
Fueredoriku
Fueredoriku approved these changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 😁👍

(Feedback recieved in the same room)

@karofmah karofmah merged commit 753567c into dev Oct 15, 2023
@karofmah karofmah deleted the feature/platform-movement branch October 15, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toberge toberge toberge approved these changes

@Fueredoriku Fueredoriku Fueredoriku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karofmah @toberge @Fueredoriku