-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Juan Zarco's PCB Business Card #363
Conversation
Hi, I'm Orpheus Leap! Here to help you review your PR.
projects/JuanZ_PCB_Card: Required files You can view a render of your board over on gerber.zip/2d! Happy OnBoarding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Scrlpter I haven't seen a student verification submitted so I can't merge this yet!
Just an fyi, your images are on the top layer, which means that they are part of the copper traces. This won't cause any issues, other than it might not look how you want it to look. I would suggest moving those to the TopSilkLayer |
Hey I appreciate the feedback, I would like to see how the layer affects the images so that I can make my diy board look the best it can!Sent from my iPhoneOn Mar 6, 2024, at 6:09 PM, BrightTheBackpack ***@***.***> wrote:
Just an fyi, your images are on the top layer, which means that they are part of the copper traces. This won't cause any issues, other than it might not look how you want it to look. I would suggest moving those to the TopSilkLayer
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@Scrlpter can you comment here once you fill out the student verification form. I see it checked off in your PR description, but I don't see it submitted on my end. |
I see the difference it makes, I changed the design to have the pokemon
TopSilkLayer, will i have to change the gerber file on the PR?
…On Wed, Mar 6, 2024 at 8:38 PM BrightTheBackpack ***@***.***> wrote:
Current:
image.png (view on web)
<https://github.com/hackclub/OnBoard/assets/78445409/25b399de-70f1-4653-bf3b-19c5160ee755>
With Silkscreen:
image.png (view on web)
<https://github.com/hackclub/OnBoard/assets/78445409/e3103e2a-fd6c-44bc-a80c-15fca7ebe57d>
—
Reply to this email directly, view it on GitHub
<#363 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BGTALJL3ELQOSBAYMVK4PH3YW7VM3AVCNFSM6AAAAABEFR7WFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBSGMZTGMZTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I have submitted the form, I did it a couple days ago also but hopefully this one gets through! |
Your design and student verification look good to me! Emailing grant now! |
Do send pictures of your card in #onboard on slack when you get it! |
Submission Checklist:
[ X] I am a current high school, middle school, or home schooled student.
[ X] I have joined the
#onboard
channel on Slack[ X] I made this board from scratch, even if I followed a tutorial
[ X] I have followed the directions in README.md
onboard/projects
TEMPLATE.md
asREADME.md
src
and uploaded design files(Optional) This project is from a tutorial1.
(Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____
Footnotes
Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩