Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zach'sPCB #277

Merged
merged 15 commits into from
Dec 16, 2023
Merged

Zach'sPCB #277

merged 15 commits into from
Dec 16, 2023

Conversation

Elementxp
Copy link
Contributor

@Elementxp Elementxp commented Dec 14, 2023 •
edited
Loading

Submission Checklist:

  • [ Y] I am a current high school, middle school, or home schooled student.

  • [ Y] I have joined the #onboard channel on Slack

  • [ Y] I made this board from scratch, even if I followed a tutorial

  • [ Y] I have followed DIRECTIONS.md

    • [ Y] Created a folder under onboard/projects
    • [ Y] Filled out TEMPLATE.md as README.md
    • [ Y] Uploaded Gerber, sources, and schematic
    • [ Y] Uploaded screenshot of PCB order with all costs included
    • [ Y] I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)

  • [ Y] (Optional) This project is from a tutorial1.

  • [ N] (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩

sarthaktexas
sarthaktexas approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@sarthaktexas sarthaktexas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Zach! I'm approving your student verification :) The next step will be to wait 24-48 hours for the technical review and then your PR will be merged and you'll receive your grant! @hackclub/boarding-party

@karmanyaahm karmanyaahm added the Submission New Boards! label Dec 15, 2023
karmanyaahm
karmanyaahm requested changes Dec 15, 2023
View reviewed changes
Copy link
Member

@karmanyaahm karmanyaahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Love the design and the red AMD theme. But, you have not selected assembly from JLCPCB, so there won't be any components installed on your board. Please check out https://github.com/hackclub/OnBoard/blob/main/docs/ordering_from_JLCPCB.md#pcb-assembly for how to do this.

Also, since these business cards will be handled a lot, I'd recommend selecting Lead Free Surface Finish in the PCB options, it will make the PCB non-toxic!

@Elementxp
Copy link
Contributor Author

Elementxp commented Dec 15, 2023 via email

@karmanyaahm
Copy link
Member

karmanyaahm commented Dec 15, 2023 via email

@Elementxp
Copy link
Contributor Author

Elementxp commented Dec 15, 2023 via email

@Elementxp
Copy link
Contributor Author

Ok, I changed it the screen
Proof
shot!

karmanyaahm
karmanyaahm approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@karmanyaahm karmanyaahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The designs LGTM. Presumably you'll remove the old set of unassembled boards from your cart, because there's no use for those. That should also make the price go down quite a bit (approx $30 before shipping) because the PCBs will cost $2.

@karmanyaahm karmanyaahm merged commit 68b7a05 into hackclub:main Dec 16, 2023
@karmanyaahm
Copy link
Member

You should get an email with your grant in ~24 business hours! Looking forward to seeing your designs, please post pictures in #onboard on Slack when you get them!

@sarthaktexas
Copy link
Member

sent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karmanyaahm karmanyaahm karmanyaahm approved these changes

@sarthaktexas sarthaktexas sarthaktexas approved these changes

Assignees
No one assigned
Labels
Submission New Boards!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elementxp @karmanyaahm @sarthaktexas