Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BENS USB HUB #275

Merged
merged 21 commits into from
Dec 16, 2023
Merged

BENS USB HUB #275

merged 21 commits into from
Dec 16, 2023

Conversation

2008wbbv
Copy link
Contributor

Submission Checklist:

  • [ x] I am a current high school, middle school, or home schooled student.

  • [x ] I have joined the #onboard channel on Slack

  • [ x] I made this board from scratch, even if I followed a tutorial

  • [ x] I have followed DIRECTIONS.md

    • [x ] Created a folder under onboard/projects
    • [x ] Filled out TEMPLATE.md as README.md
    • [ x] Uploaded Gerber, sources, and schematic
    • [x ] Uploaded screenshot of PCB order with all costs included
    • [x ] I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • [ x] If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)
  • [x ] (Optional) This project is from a tutorial1.

  • (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials.

Copy link
Member

@maxwofford maxwofford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @2008wbbv, it's awesome to see how much cheaper your USB hub is than mine, great work with changing the shape!

It looks like something happened on your upload and this is missing a couple files. Could you upload all the missing files on your card project and the schematic.pdf part of the usb hub?

@maxwofford maxwofford added the Submission New Boards! label Dec 13, 2023
@2008wbbv
Copy link
Contributor Author

What's missing other than the schematic? I put that in when i get the chance.

@maxwofford
Copy link
Member

@2008wbbv oh, looks like all the files are there now! Our script just isn't detecting them because of the filenames. Could you rename them to:

  • screenshot.png
  • gerber.zip
  • bom.csv
  • pickandplace.csv
  • schematic.pdf

@maxwofford
Copy link
Member

@sarthaktexas is this approved on the HCB side?

Copy link
Member

@sarthaktexas sarthaktexas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ben has been approved before! Thanks for submitting another PR :)

@2008wbbv
Copy link
Contributor Author

renamed.

Copy link
Member

@karmanyaahm karmanyaahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for taking over your PR max
It's awesome to see you submitting another project Ben! Since the last time you submitted we've started requiring some additional files, I've renamed all the ones you've already posted to the right names.

Copy link
Member

@karmanyaahm karmanyaahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a "src" folder in projects/BENS NEW CARD/ and projects/BENS USB HUB/, and put your project sources there. They should be two .JSON files for each project, one from the schematic tab, one from the PCB tab. They look something like PCB.....name...json and SCH_SCH.....name....json

@2008wbbv
Copy link
Contributor Author

I had that project backed up, the other one, the usb hub I didnt because I was on a guest account, and for opsec reasons I delete cookies every 12 hours, so I longer have those source files.

Copy link
Member

@karmanyaahm karmanyaahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks

@karmanyaahm karmanyaahm merged commit 9575618 into hackclub:main Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submission New Boards!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants