Add my project (Darren's Keyboard) #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmanyaahm
reviewed
Oct 30, 2023
|
The parts that I needed is using an extended part so yes
…On Mon, Oct 30, 2023, 10:11 AM Karmanyaah Malhotra ***@***.***> wrote:
***@***.**** commented on this pull request.
Very cool! Are you intentionally using standard assembly? Economic
assembly might be a lot cheaper if you can substitute some parts for ones
that are economic supported. Just want to confirm that you are aware of
that, other than that LGTM.
—
Reply to this email directly, view it on GitHub
<#237 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO6YPGGKQVLMFKCWIT6DKTTYB4EFZAVCNFSM6AAAAAA6TNFJR6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBTGE2DMMJTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
karmanyaahm
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
LGTM. You can get extended parts with economic assembly. I'm assuming you're referring to the "Standard only" ESP32 S2 WROVER? You can proceed as is, but I'd suggest trying to swap that out for a module that is not "Standard only". You can save a lot of money (like $30-$40) and make more boards with that.
|
@karmanyaahm thanks |
|
HCB team still needs to review this (and several other PRs), and they're super busy rn, but I'm sure they'll get to our fairly soon |
daisybanks
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Approving student verification merging pr, and sending grant now! Thanks so much @mickeydarrenlau for your patience! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist:
I am a current high school, middle school, or home schooled student.
I have joined the
#onboardchannel on SlackI made this board from scratch, even if I followed a tutorial
I have followed DIRECTIONS.md
onboard/projectsTEMPLATE.mdasREADME.md(Optional) This project is from a tutorial1.
Footnotes
Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩