Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/captions-default-to-off #190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feature/captions-default-to-off #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfd46dd
makes default captions set to Off if left empty
rider-griffin Jul 2, 2021
7e43239
makes the textbox default to Off
rider-griffin Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions semantics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@
"name": "defaultTrackLabel",
"type": "text",
"label": "Default text track",
"default": "Off",
"description": "If left empty or not matching any of the text tracks the first text track will be used as the default.",
"importance": "low",
"optional": true
Expand Down
2 changes: 2 additions & 0 deletions src/scripts/interactive-video.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,8 @@ InteractiveVideo.prototype.setCaptionTracks = function (tracks) {
currentTrack = tracks[0];
}

self.video.setCaptionsTrack(null);

// Create new track selector
self.captionsTrackSelector = new SelectorControl('captions', tracks, currentTrack, 'menuitemradio', self.l10n, self.contentId);

Expand Down