Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions Tidy-up #3114

Merged
merged 1 commit into from
Apr 23, 2024
Merged

GitHub Actions Tidy-up #3114

merged 1 commit into from
Apr 23, 2024

Conversation

coliff
Copy link
Member

@coliff coliff commented Apr 16, 2024

Types of changes

  • Allow CodeQL workflow to be run from GitHub Actions WebUI at any time
  • Set CodeQL to also check for best practises/code problems (as well as security)
  • Capitalize Publish GH Action
  • Change Windows Test workflow for consistent file extension (also means its formatted with Prettier) and remove leading empty linebreak and change title to seperate it from Ubuntu one
  • Run Prettier (maybe we should add this to build script to ensure all code is formatted?)
  • Change .gitattributes to have LF line-endings for more file types

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coliff coliff added the github_actions Pull requests that update Github_actions code label Apr 16, 2024
@coliff coliff requested a review from roblarsen April 16, 2024 15:09
@coliff
GitHub Actions Tidy-up
b02e6a3 
- Allow CodeQL workflow to be run from GitHub Actions WebUI at any time
- Set CodeQL to also check for best practises/code problems (as well as security)
- Capitalize Publish GH Action
- Change Windows Test workflow for consistent file extension (also means its formatted with Prettier) and remove leading empty linebreak
- Run Prettier (maybe we should add this to build script to ensure all code is formatted?)
- Change .gitattributes to have LF line-endings for more file types
roblarsen
roblarsen approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@roblarsen roblarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@roblarsen roblarsen merged commit 07e9dc6 into main Apr 23, 2024
9 checks passed
@roblarsen roblarsen deleted the dev/co;liff/github-actions-tidyup branch April 23, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblarsen roblarsen roblarsen approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coliff @roblarsen