Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 16 no longer supported? #3091

Closed
wants to merge 2 commits into from
Closed

node 16 no longer supported? #3091

wants to merge 2 commits into from

Conversation

bbannon
Copy link

@bbannon bbannon commented Mar 7, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thanks!

@coliff coliff marked this pull request as draft March 8, 2024 01:32
@coliff
Copy link
Member

coliff commented Mar 8, 2024

If we were to drop Node 16 support there are other places it needs updating in, such as the package.json and maybe the README or docs?

@bbannon
Copy link
Author

bbannon commented Mar 8, 2024 via email

@roblarsen
Copy link
Member

@roblarsen
Copy link
Member

I'm going to make these changes myself.

@roblarsen roblarsen closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants