node 18+ (#3104)

* node 18+ * Remove LGTM mention (service is no longer available) --------- Co-authored-by: Christian Oliff <[email protected]>
h5bp · Apr 8, 2024 · d00a4b9 · d00a4b9
1 parent 6782409
commit d00a4b9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16.x, 18.x]
+        node-version: [18.x, 20.x]
     steps:
       - name: Get npm cache directory
         id: npm-cache

diff --git a/docs/about-this-repo.md b/docs/about-this-repo.md
@@ -50,8 +50,8 @@ Our branch protection rules are as follows:
 - We require a pull request (PR) with one approving reviewer to merge code
 - In addition to the PR and approving reviewer, we require three status checks
   to pass before code can be merged
+  _ Build with Node 20
   _ Build with Node 18
-  _ Build with Node 16 \* LGTM analysis: JavaScript
 - We _allow_ force pushes for project admins. While force pushes can create
   some head scratching moments for people who have cloned the repo and update
   before and after the force push, the ability to clean up the `HEAD` of a

diff --git a/package.json b/package.json
@@ -39,8 +39,8 @@
     "strip-json-comments": "^5.0.1"
   },
   "engines": {
-    "node": ">=16",
-    "npm": ">=8"
+    "node": ">=18",
+    "npm": ">=10"
   },
   "h5bp-configs": {
     "directories": {