Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add docker-compose.yml #122

Merged
merged 7 commits into from
Nov 13, 2023
Merged

Feat: Add docker-compose.yml #122

merged 7 commits into from
Nov 13, 2023

Conversation

denzuko
Copy link
Contributor

@denzuko denzuko commented Oct 10, 2023

Description:
Added docker-compose support because "docker_is_hard™" but "docker-compose up is for dummies®". Satire aside; I'm actually using this in production and figured it would help get the community onboarded quicker.

Related Issues (optional):
h2oai/wave#1699

Added docker-compose support because "docker_is_hard™" but "`docker-compose up` is for dummies®". Satire aside; I'm actually using this in production and figured it would help get the community onboarded quicker.
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @denzuko! Please mention docker compose as an alternative to the existing Docker in README together with running instructions and and potential caveats (networking).

docker-development/docker-compose.yml Outdated Show resolved Hide resolved
docker-development/docker-compose.yml Outdated Show resolved Hide resolved
Implements suggested changes for MacOS users.
Implements suggested changes to document docker-compose usage.
@denzuko
Copy link
Contributor Author

denzuko commented Nov 12, 2023

Thanks for your contribution @denzuko! Please mention docker compose as an alternative to the existing Docker in README together with running instructions and and potential caveats (networking).

The suggested changes have been added.

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @denzuko!

@mturoci mturoci merged commit 97f4ed8 into h2oai:main Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants