Skip to content
This repository has been archived by the owner on Nov 29, 2024. It is now read-only.

Address memory issue caused by open api generator #385

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

jackjii79
Copy link
Contributor

@jackjii79 jackjii79 commented Mar 12, 2024

https://h2oai.slack.com/archives/G01C9KKQLAC/p1710175541471659

The root cause of performance issue is due to auto generated api model class should using Row class instead of ArrayList<String>, which makes JVM spend more than necessary heap size to do the class conversion results in slowness and abnormal memory increasing.
This PR also removes deprecated sub gradle project from building pipeline

@jackjii79 jackjii79 added bug Something isn't working area/rest labels Mar 12, 2024
@jackjii79 jackjii79 requested review from g-eoj, shsma and mwysokin March 12, 2024 18:43
@jackjii79 jackjii79 self-assigned this Mar 12, 2024
Copy link
Contributor

@g-eoj g-eoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't see any issues but prefer someone with more Java experience to give approval.

include 'aws-lambda-scorer:lambda-template'
include 'aws-lambda-scorer:terraform-recipe'
include 'common:jdbc'
//include 'aws-lambda-scorer:lambda-template'
Copy link
Contributor Author

@jackjii79 jackjii79 Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All deprecated scorer which not only takes long time to build also no longer used by MLOps

@jackjii79
Copy link
Contributor Author

@jackjii79 jackjii79 requested a review from aravind-vis March 12, 2024 21:26
Copy link
Member

@shsma shsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jackjii79

@jackjii79 jackjii79 merged commit ef6af18 into master Mar 13, 2024
9 of 10 checks passed
@jackjii79 jackjii79 deleted the address-openapi-generator-incorrect branch March 13, 2024 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/rest bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants