-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebook tutorial for using the Drive Python client. #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is amazing! I have just a few comments, which I will not do in-line as that's hard for notebooks
- "nice to have" the other notebooks in this repo use get pass instead of import urllib.parse, that might be nice to be more consistent
- Do we allow users to access Managed Cloud drive from their local machine? I think not. we should add a note that this will only run in notebooks in the cloud (if that is the case). and if that IS the case, we could use the MC platform token variable instead of having to click the link?
- I like the custom buckets section, thank you for keeping that in. If I try to create a custom bucket that already exists, I am allowed to... 😱 but then the list command fails with an authorization error. I changed the name to have my initials and then listing on the it worked. Maybe the tutorial can append a random number?
- Should we delete the custom bucket? Is it bad to have 100 demo test buckets???
…ooks, for consistency. Added note that notebook only runs on the cloud. Randomized custom bucket names. Added cleanup of files that were pushed but never deleted.
You got it - done.
Sounds good - done.
I wasn't able to find a platform token (or anything that would let us skip the link stage) in any variable in the environment (specifically, no where in
Great catch, thank you! I've randomized the name so as to avoid name collisions.
Great idea. Unfortunately, there will need to be a few changes to enable. I've opened a corresponding feature request (not linked here as it leads to a non-public repo). Also added cleanup to remove demo test files that were written but not deleted. |
This notebook has been updated once again with the latest features, including automatic ("authless") connection to Drive. |
Closing in favor of new Drive tutorials which use Drive's new Python client: |
Adds a notebook guiding users through the different features of the Drive Python client.
Rendered view for convenience: https://github.com/h2oai/haic-tutorials/blob/eo/drive-notebook/6%20Drive:%20Python%20Client.ipynb
Important
The author still needs to verify that this notebook indeed runs as intended on the latest Managed Cloud offering. The PR will come out of draft mode when completed.✅ The notebook has been verified against the latest Managed Cloud offering currently in queue for release.