Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-16425 Add JDBC parameter validation [nocheck] #16432

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

krasinski
Copy link
Contributor

@krasinski krasinski commented Oct 22, 2024

fixes #16425

wendycwong
wendycwong previously approved these changes Oct 22, 2024
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should go to the rel-3.46.0 I suppose

@wendycwong wendycwong changed the base branch from master to rel-3.46.0 October 23, 2024 15:40
@wendycwong wendycwong dismissed their stale review October 23, 2024 15:40

The base branch was changed.

@wendycwong
Copy link
Contributor

@valenad1 : If I remember correctly, this is the second time you remind the team to use rel-3.46.0 and not the master branch. LOL.

wendycwong
wendycwong previously approved these changes Oct 23, 2024
@valenad1 valenad1 self-requested a review October 23, 2024 15:49
@valenad1
Copy link
Collaborator

It happens, make sense sometime to merge it to master first and cherry-pick to rel-* later, but I want to be sure, it is this purpose or mistake :)

valenad1
valenad1 previously approved these changes Oct 23, 2024
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wendycwong wendycwong changed the title GH-16425 Add JDBC parameter validation GH-16425 Add JDBC parameter validation [nocheck] Oct 23, 2024
@krasinski krasinski dismissed stale reviews from valenad1 and wendycwong via d5e0a07 October 25, 2024 13:25
@wendycwong wendycwong merged commit ac1d642 into rel-3.46.0 Oct 27, 2024
75 of 77 checks passed
@wendycwong wendycwong deleted the gh-16425-add-disallowed-jdbc-parameters branch October 27, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2024-8862 JDBC connector
3 participants