GH-15893: rename 'partial_plot' 'data' param to 'frame' for consistency #15895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e old param as deprecated
sebhrusen
changed the title
wendycwong
reviewed
Oct 31, 2023
mn-mikke
previously approved these changes
Nov 1, 2023
tomasfryda
reviewed
Nov 2, 2023
tomasfryda
reviewed
Nov 6, 2023
tomasfryda
previously approved these changes
Nov 6, 2023
… available only since 4.1.0
tomasfryda
previously approved these changes
Nov 6, 2023
sebhrusen
commented
Nov 6, 2023
sebhrusen
commented
Nov 6, 2023
@tomasfryda any reference for API changes on the web or to browse old doc easily? What I found:
|
tomasfryda
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue: #15893
Python client
Deprecating
dataparam on functionpartial_plotand forward to new param nameframefor consistency with other plot functions.R client
Deprecating
dataparam on functionpartialPlotand forward to new param namenewdatafor consistency with other R plot functions.Note that the "standard" param name in R is different than in Python. We probably wanted to use a standard R param name instead of prioritizing compatibility with Py API.