Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-6570 Add Friedman and Popescu's H statistics doc (GBM, XGBoost) #15879

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

maurever
Copy link
Contributor

Issue: #6570

@maurever maurever added this to the 3.44.0.2 milestone Oct 26, 2023
@maurever maurever self-assigned this Oct 26, 2023
@maurever maurever requested a review from wendycwong October 26, 2023 09:03
@maurever
Copy link
Contributor Author

@hannah-tillman @wendycwong, I added a new section to the GBM and XGBoost section. I am not sure if it is okay, or if we have a better place to document it.

@maurever maurever changed the title Add Friedman and Popescu's H statistics doc (GBM, XGBoost) GH-6570 Add Friedman and Popescu's H statistics doc (GBM, XGBoost) Oct 30, 2023
@wendycwong
Copy link
Contributor

I have no problem with the writing. @hannah-tillman : Please approve after resolving all issues.

Copy link
Contributor

@hannah-tillman hannah-tillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks :)

@maurever maurever merged commit 12d208b into rel-3.44.0 Nov 1, 2023
2 checks passed
@maurever maurever deleted the maurever_GH-6570_friedman_h_statistics branch November 1, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants