Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15860: fixed problem with skipped columns. #15867

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

wendycwong
Copy link
Contributor

This PR fixes the problem in issue: #15860

The problem is: the column types of the frame without skipped column is used when trying to force column types. When there are skipped columns, the frame will not have the removed columns in it. Hence, the problem is resolved when I removed the skipped columns from the column types.

mn-mikke
mn-mikke previously approved these changes Oct 25, 2023
Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

h2o-core/src/main/java/water/parser/ParseDataset.java Outdated Show resolved Hide resolved
Copy link
Contributor

@maurever maurever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wendycwong !

@wendycwong wendycwong force-pushed the wendy_gh_15860_force_col_types branch from c21a63d to 7e97999 Compare October 26, 2023 18:25
@wendycwong wendycwong merged commit ac63da6 into rel-3.44.0 Oct 30, 2023
@wendycwong wendycwong deleted the wendy_gh_15860_force_col_types branch October 30, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter force_col_type does not work with skipped_columns when parsing parquet files
3 participants