Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-15654] Introduce MLFlow flavor for working with mojos and pojos #15849

Merged
merged 43 commits into from
Nov 14, 2023

Conversation

mn-mikke
Copy link
Collaborator

Closes GH-15654

@mn-mikke mn-mikke marked this pull request as ready for review November 13, 2023 15:10
krasinski
krasinski previously approved these changes Nov 13, 2023
Copy link
Contributor

@krasinski krasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply awesome @mn-mikke 💪 I really like the docs

@mn-mikke mn-mikke changed the title [GH-15654] Introduce MLFlow flavors for working with mojos and pojos [GH-15654] Introduce MLFlow flavor for working with mojos and pojos Nov 14, 2023
@valenad1
Copy link
Collaborator

valenad1 commented Nov 14, 2023

Question:

How we will declare compatibility with h2o-3? Is it going to be same as h2o clients - equal, it means that with each release we release also ml-flow? Or the mlflow flavor will be compatible with future version unless we say otherwise. What is the lowest version we declare to support - 3.46.0.1?

The easiest would be to match h2o-3 version IMHO.

Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, thank you!

@valenad1
Copy link
Collaborator

Question:

How we will declare compatibility with h2o-3? Is it going to be same as h2o clients - equal, it means that with each release we release also ml-flow? Or the mlflow flavor will be compatible with future version unless we say otherwise. What is the lowest version we declare to support - 3.46.0.1?

The easiest would be to match h2o-3 version IMHO.

Its separate from H2O-3, it uses only basic API and should be compatible across previous and future versions.

@mn-mikke mn-mikke merged commit d6c889b into master Nov 14, 2023
1 of 2 checks passed
@mn-mikke mn-mikke deleted the mn/GH-15654 branch November 14, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce MLFlow flavors for working with mojos and pojos
3 participants