GH-15839: move explain related tests to one stage #15844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The run.py when provided with a test list runs everything on the test list so we need to exclude NOPASS from the testlist. When running the other tests the list .lookup is used as exclude list and the NOPASS tests are excluded while searching for the tests.
tomasfryda
commented
Oct 19, 2023
scripts/jenkins/Makefile.jenkins
Outdated
| find h2o-r/tests -name '*explain*.R' -exec basename {} \; >>h2o-r/tests/.lookup.txt | ||
| find h2o-py/tests -name '*explain*.py' -exec basename {} \; >>h2o-py/tests/.lookup.txt | ||
| find h2o-r/tests/testdir_misc/explain -name '*.R' -exec basename {} \; | grep -v NOPASS >>h2o-r/tests/.lookup.txt | ||
| find h2o-py/tests/testdir_misc/explain -name '*.py' -exec basename {} \; | grep -v NOPASS >>h2o-py/tests/.lookup.txt |
There was a problem hiding this comment.
The .lookup.txt serves as test list in the run.py. When the test is in the test list we run it even if it is NOPASS. Since the SHAP_NOPASS can take a day to finish I skip it here.
When we run pyunit-small etc. the .lookup.txt serves as exclude list - run.py excludes those tests and then finds the remaining tests while skipping the NOPASS tests. (
Lines 1344 to 1347 in 1e4e8ca
mn-mikke
previously approved these changes
Oct 19, 2023
|
Not so great, we apparently call lookup even when there are no tests (I think before we checkout the repo). Hopefully, I fixed that. I will ask you for review again once I'm sure everything is ok. Sorry for wasting your time @mn-mikke. |
tomasfryda
force-pushed
the
tomf_gh-15839_move_explain_related_tests_to_one_stage
branch
from
58f6d53 to
7f35c6d
Compare
tomasfryda
deleted the
tomf_gh-15839_move_explain_related_tests_to_one_stage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15839