Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-15832 Fix UpliftDRF MOJO API, add docs, tests #15838

Merged
merged 5 commits into from
Nov 1, 2023
Merged

GH-15832 Fix UpliftDRF MOJO API, add docs, tests #15838

merged 5 commits into from
Nov 1, 2023

Conversation

maurever
Copy link
Contributor

@maurever maurever commented Oct 17, 2023 •
edited
Loading

Issue: #15832

TODO:

  • fix API
  • fix documentation
  • add Python and R test for MOJO

@maurever maurever added the bug label Oct 17, 2023
@maurever maurever added this to the 3.44.0.2 milestone Oct 17, 2023
@maurever maurever self-assigned this Oct 17, 2023
@maurever maurever marked this pull request as draft October 18, 2023 06:11
@maurever maurever marked this pull request as ready for review October 25, 2023 14:57
valenad1
valenad1 previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, thank you! We need to try python API next time..

@maurever maurever requested a review from valenad1 November 1, 2023 10:41
valenad1
valenad1 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maurever maurever merged commit c9e1ff2 into rel-3.44.0 Nov 1, 2023
2 checks passed
@maurever maurever deleted the maurever_GH-15832_upliftdrf_mojo_doc branch November 1, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valenad1 valenad1 valenad1 approved these changes

@wendycwong wendycwong Awaiting requested review from wendycwong

Assignees

@maurever maurever

Labels
bug
Projects
None yet
Milestone
3.44.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@maurever @valenad1