Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-6783 Add custom metric function to UpliftDRF #15592

Merged
merged 19 commits into from
Sep 15, 2023
Merged

GH-6783 Add custom metric function to UpliftDRF #15592

merged 19 commits into from
Sep 15, 2023

Conversation

maurever
Copy link
Contributor

@maurever maurever commented Jun 19, 2023 •
edited
Loading

  1. Implement ATE, ATT, ATC metrics
  2. Implement custom metric functionality
  3. Add examples and tests

Closes #6783

@maurever maurever self-assigned this Jun 19, 2023
@maurever maurever changed the title GH-6783 Add custom metric function to UpliftDRF GH-6783 Add custom metric function to UpliftDRF [no-check] Jun 19, 2023
@maurever maurever changed the title GH-6783 Add custom metric function to UpliftDRF [no-check] GH-6783 Add custom metric function to UpliftDRF [nocheck] Jun 22, 2023
@maurever maurever added this to the 3.44.0.1 milestone Jun 27, 2023
@maurever maurever marked this pull request as draft June 27, 2023 14:39
@maurever maurever changed the title GH-6783 Add custom metric function to UpliftDRF [nocheck] GH-6783 Add custom metric function to UpliftDRF Jul 17, 2023
@maurever maurever marked this pull request as ready for review August 9, 2023 11:56
@maurever maurever requested review from valenad1 and wendycwong August 9, 2023 11:56
@maurever maurever force-pushed the maurever_GH-6783_add_custom_metric_uplift branch from f271745 to fa5b011 Compare August 14, 2023 08:22
wendycwong
wendycwong previously approved these changes Aug 14, 2023
View reviewed changes
@maurever maurever requested a review from wendycwong August 17, 2023 09:36
@maurever maurever merged commit 4c5a01b into master Sep 15, 2023
2 checks passed
@maurever maurever deleted the maurever_GH-6783_add_custom_metric_uplift branch September 15, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendycwong wendycwong wendycwong approved these changes

@valenad1 valenad1 Awaiting requested review from valenad1

Assignees

@maurever maurever

Labels
Uplift Trees
Projects
None yet
Milestone
3.44.0.1
Development

Successfully merging this pull request may close these issues.

Add custom_metric_func for uplift trees. Make sure they show up in the model summary.
2 participants
@maurever @wendycwong